This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
add rotate transforms for image #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hakuyume
reviewed
Sep 12, 2018
| class TestRotate(unittest.TestCase): | ||
|
|
||
| def test_rotate(self): | ||
| img = np.random.uniform(size=(3, 24, 24)) |
There was a problem hiding this comment.
How about using non-square image for test?
|
Could you change argument |
|
i think continuous rotate support is different problem. |
|
Updated to use |
yuyu2172
reviewed
Sep 18, 2018
chainercv/transforms/image/rotate.py
Outdated
| """Rotate images by degrees. | ||
|
|
||
| Args: | ||
| img (~numpy.ndarray): An arrays that get flipped. This is in |
| _available = False | ||
|
|
||
|
|
||
| def _check_available(): |
There was a problem hiding this comment.
I checked scipy availablity at the top of rotate function.
chainercv/transforms/image/rotate.py
Outdated
| CHW format. | ||
| angle (float): Clock-wise rotation angle (degree) in [-180, 180]. | ||
| expand (bool): The output shaped is adapted or not. | ||
| If `True`, the input image is contained completel in the output. |
yuyu2172
reviewed
Sep 18, 2018
chainercv/transforms/image/rotate.py
Outdated
| Args: | ||
| img (~numpy.ndarray): An arrays that get flipped. This is in | ||
| CHW format. | ||
| angle (float): Clock-wise rotation angle (degree) in [-180, 180]. |
There was a problem hiding this comment.
yuyu2172
approved these changes
Sep 19, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
rotateforimg.random_rotateexists butrotatedoes not exists.