Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Fix Chainer version in Travis #351

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

Hakuyume
Copy link
Member

@Hakuyume Hakuyume commented Jul 21, 2017

Another version of #349. In this version, we don't have to update miner version of v2.

@yuyu2172
Copy link
Member

It is OK this time, but can you not make a duplicate PR?

@yuyu2172
Copy link
Member

LGTM

@yuyu2172 yuyu2172 merged commit 4eb78bd into chainer:master Jul 21, 2017
@yuyu2172 yuyu2172 added this to the v0.7 milestone Jul 21, 2017
@Hakuyume
Copy link
Member Author

can you not make a duplicate PR?

I'm sorry. I thought making a new commit is easier than commenting your existing PR.

@yuyu2172
Copy link
Member

I understand that.
How about sending a PR to my branch?

I do not like to have a duplicate PR at chainer/chainercv because the older PR has to be closed.

@Hakuyume
Copy link
Member Author

How about sending a PR to my branch?

OK, I will do so from next time.

@Hakuyume Hakuyume deleted the fix-chainer-version-in-travis branch August 1, 2017 16:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants