Add Conv2DActiv #384
Add Conv2DActiv #384
Conversation
|
|
||
| >>> l = Conv2DActiv(5, 10, 3) | ||
|
|
||
| 2. Omit :obj:`in_channels` or fill it with :obj:`None`: |
There was a problem hiding this comment.
The order of descriptions should be same as that of examples.
I mean, Fill :obj:in_channels with :obj:None: or omit it: is better. (Changing the order of examples is also OK)
chainercv/links/__init__.py
Outdated
| @@ -1,3 +1,5 @@ | |||
| from chainercv.links.connection.conv_2d_activ import Conv2DActiv | |||
There was a problem hiding this comment.
How about block instead of connection? connection sounds too ambiguous.
There was a problem hiding this comment.
I made it to be consistent with the Chainer's directory structure.
connection seems to include links with learnable parameters (e.g. Convolution2D) and a block of them (e.g. Inception).
If we change the directory structure, we need to come up with a new name for group of links that are not blocks, but categorized under connection.
There was a problem hiding this comment.
I made it to be consistent with the Chainer's directory structure.
I see. connection is OK.
| {'args_style': 'None'}, | ||
| {'args_style': 'omit'} | ||
| ) | ||
| class TestConv2DActivForward(unittest.TestCase): |
There was a problem hiding this comment.
Can you merge TestConv2DActivForward and TestConv2DActivBarckward into one class?
| @testing.parameterize( | ||
| {'args_style': 'explicit'}, | ||
| {'args_style': 'None'}, | ||
| {'args_style': 'omit'} |
There was a problem hiding this comment.
How about this ?
'args_style': ['explicit', 'None', 'omit'],
'activ: [None, _add_one]
|
I reflected your comments. |
Split from #265.