Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

avoid zero division in bbox2loc #459

Merged
merged 1 commit into from
Oct 20, 2017

Conversation

knorth55
Copy link
Contributor

No description provided.

@yuyu2172
Copy link
Member

yuyu2172 commented Oct 20, 2017

How about np.minimum(..., 1e-14)?

@Hakuyume
Copy link
Member

Hakuyume commented Oct 20, 2017

How about using eps which can get from numpy.finfo(https://docs.scipy.org/doc/numpy-1.13.0/reference/generated/numpy.finfo.html) instead of magic value 1e-14?

@Hakuyume
Copy link
Member

This is just a question. Are there any cases that height or width becomes 0? According to assert_is_bbox, both height and width should be a positive number (https://github.com/chainer/chainercv/blob/master/chainercv/utils/testing/assertions/assert_is_bbox.py#L25-L28).

@knorth55
Copy link
Contributor Author

rpn output rois can be height =0 and width = 0 at initial state in training.
and this rois can be used proposal_target_creator

@knorth55
Copy link
Contributor Author

thank you for review.
I updated

@Hakuyume
Copy link
Member

rpn output rois can be height =0 and width = 0 at initial state in training.
and this rois can be used proposal_target_creator

I see. That makes sense.

Copy link
Member

@Hakuyume Hakuyume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@Hakuyume Hakuyume merged commit 1b6314f into chainer:master Oct 20, 2017
@knorth55 knorth55 deleted the avoid-zero-division-bbox2loc branch October 20, 2017 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants