Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Update to v0.8.0 #500

Merged
merged 2 commits into from
Dec 20, 2017
Merged

Update to v0.8.0 #500

merged 2 commits into from
Dec 20, 2017

Conversation

yuyu2172
Copy link
Member

@yuyu2172 yuyu2172 mentioned this pull request Dec 19, 2017
Merged
@yuyu2172 yuyu2172 added this to the v0.8 milestone Dec 20, 2017
@yuyu2172
Copy link
Member Author

@Hakuyume

@Hakuyume Hakuyume self-assigned this Dec 20, 2017
@Hakuyume
Copy link
Member

Hakuyume commented Dec 20, 2017 •
edited
Loading

@yuyu2172 Could you update these lines? (I'm sorry for not updating them in #445)
https://github.com/chainer/chainercv/blob/master/setup.py#L25
https://github.com/chainer/chainercv/blob/master/docs/requirements.txt#L1

@Hakuyume
Copy link
Member

I confirmed that nosetests (w/o disk) passed successfully in both Chainer/CuPy 3.2 and Chainer/CuPy 4.0.0b2.

@yuyu2172
Copy link
Member Author

yuyu2172 commented Dec 20, 2017 •
edited
Loading

Thanks. I fixed the code.

Hakuyume
Hakuyume approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member

@Hakuyume Hakuyume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hakuyume Hakuyume merged commit 7c0fb14 into chainer:master Dec 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hakuyume Hakuyume Hakuyume approved these changes

Assignees

@Hakuyume Hakuyume

Labels
enhancement
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@yuyu2172 @Hakuyume