Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Use prob more strictly inside SSD and Faster R-CNN #584

Merged
merged 3 commits into from
May 1, 2018

Conversation

yuyu2172
Copy link
Member

We should use prob whenever possible.

@yuyu2172 yuyu2172 added this to the 0.10 milestone Apr 24, 2018
@yuyu2172 yuyu2172 changed the title Use probability more strictly inside SSD and Faster R-CNN Use prob more strictly inside SSD and Faster R-CNN Apr 24, 2018
@Hakuyume
Copy link
Member

Hakuyume commented Apr 25, 2018

We cannot assume that all models return a value in [0, 1] as a confidential score.
We should define the API to fit all models.
It is confusing that SSD and Faster R-CNN return probs and another model returns scores.

@yuyu2172
Copy link
Member Author

None of them return probs. The internal naming is changed to be more explicit.

@Hakuyume
Copy link
Member

Hakuyume commented Apr 26, 2018

None of them return probs.

Sorry, it's my misunderstanding.

The internal naming is changed to be more explicit.

Using both score and prob is confusing. I don't think this modification improves readability.

@yuyu2172
Copy link
Member Author

Using both score and prob is confusing. I don't think this modification improves readability.

I agree. It is not necessary to enforce this rule.

Copy link
Member

@Hakuyume Hakuyume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hakuyume Hakuyume merged commit a089653 into chainer:master May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants