Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

add fcis examples_tests #840

Merged
merged 8 commits into from
Apr 23, 2019
Merged

add fcis examples_tests #840

merged 8 commits into from
Apr 23, 2019

Conversation

knorth55
Copy link
Contributor

@knorth55 knorth55 commented Mar 26, 2019 •
edited
Loading

add fcis example_tests

@knorth55 knorth55 added this to the 0.13 milestone Mar 28, 2019
@Hakuyume
Copy link
Member

Hakuyume commented Apr 3, 2019

In #842, I modified pfcCI to check examples_tests. After that PR is merged, I'll check this PR.

@Hakuyume
Copy link
Member

Hakuyume commented Apr 3, 2019

@knorth55 Can you merge master branch into this PR? I added two environment variables PFNCI_SKIP and SAMPLE that will help you to write example tests. Please use them.

@knorth55
Copy link
Contributor Author

knorth55 commented Apr 3, 2019

@Hakuyume I updated to use SAMPLE and PFNCI_SKIP.

@knorth55
Copy link
Contributor Author

knorth55 commented Apr 4, 2019

@Hakuyume Now, I really updated.

@knorth55
Copy link
Contributor Author

I merge origin/master.

@Hakuyume
Copy link
Member

pfnCI, test this please

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 9cd1fda (29a9e27):

@knorth55
Copy link
Contributor Author

@Hakuyume I updated. can you start test again?

@Hakuyume
Copy link
Member

pfnCI, test this please

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 8fe04c3 (63ab7d0):

@Hakuyume Hakuyume merged commit ef784bb into chainer:master Apr 23, 2019
@knorth55 knorth55 deleted the add-fcis-examples-test branch April 23, 2019 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hakuyume Hakuyume Hakuyume approved these changes

Assignees

@Hakuyume Hakuyume

Labels
enhancement test
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.
3 participants
@knorth55 @Hakuyume @pfn-ci-bot