Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Add DB option enable to select other DB #153

Merged
merged 8 commits into from
Sep 11, 2018

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Aug 31, 2018

This PR is for supporting other DB, such as MySQL or PostgreSQL

  • split DB_* to chainerui.db
    • DB engine and session are set in chainerui.db
  • add --db option, ex: chainerui --db <db-url> server
    • if --db is empty, use SQLite
  • fix miner bug
  • refactoring test_app.py, simplified

I'll sent another PR

  • document
  • add test using other DB

@disktnk disktnk requested a review from makky3939 August 31, 2018 08:26
@disktnk disktnk added this to the v0.6.0 milestone Aug 31, 2018
@disktnk
Copy link
Member Author

disktnk commented Sep 7, 2018

Test environment memo:

  • Docker version 17.12.1-ce, build 7390fc6

PostgreSQL

  • Postgres 10.5
  • psycopg2-binary 2.7.5
  • URL example: postgresql://user:pass@localhost:5432

MySQL

  • MySQL 8.012
  • mysqlclient 1.3.8
  • URL example: mysql+mysqldb://user:pass@127.0.0.1:3306/chainerui

@disktnk disktnk modified the milestones: v0.6.0, v0.5.1 Sep 7, 2018
@makky3939
Copy link
Contributor

LGTM

I tried this p-r with postgres, mysql and sqlite(specified).

@makky3939 makky3939 merged commit d31b93c into chainer:master Sep 11, 2018
@disktnk disktnk deleted the feature/custom-db branch September 11, 2018 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants