Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Highlight table row and chart line #186

Merged
merged 4 commits into from
Nov 13, 2018
Merged

Highlight table row and chart line #186

merged 4 commits into from
Nov 13, 2018

Conversation

ofk
Copy link
Member

@ofk ofk commented Oct 10, 2018

2018-10-10 15 20 06

@ofk ofk requested a review from makky3939 October 10, 2018 06:21
@disktnk disktnk added this to the v0.7.0 milestone Oct 11, 2018
@makky3939
Copy link
Contributor

makky3939 commented Oct 15, 2018 •
edited
Loading

LGTM

I'm concerned about the performance of UI response when there are many results.

and selected status will be initialized when new results fetched.

@ofk ofk force-pushed the reactive-chart-line branch 3 times, most recently from 04ce681 to 8224807 Compare October 18, 2018 03:48
makky3939
makky3939 approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@makky3939 makky3939 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙇

@ofk ofk force-pushed the reactive-chart-line branch from b778464 to bb9de34 Compare November 13, 2018 03:26
@makky3939 makky3939 merged commit af3fc34 into chainer:master Nov 13, 2018
@ofk ofk deleted the reactive-chart-line branch November 16, 2018 00:40
This was referenced Nov 16, 2018
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@makky3939 makky3939 makky3939 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ofk @makky3939 @disktnk