This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Download chart with legend #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofk
reviewed
Oct 16, 2018
| @@ -1,10 +1,9 @@ | |||
| import path from 'path'; | |||
| import saveSvgAsPng from 'save-svg-as-png'; | |||
There was a problem hiding this comment.
If you stop to use save-svg-as-png, you should run npm un save-svg-as-png.
There was a problem hiding this comment.
Thank you. I executed npm un save-svg-as-png .
| downloadFile(fileName, dataURL); | ||
| }; | ||
|
|
||
| export const downloadChartAsPng = async (chartDOMNode, exportName) => { |
There was a problem hiding this comment.
Is aysnc & await available? I don't know that @babel/env supports it. There is no problem if possible.
There was a problem hiding this comment.
Yes. I confirmed babel transpiles async/await correctly with current config.
|
please merge #204 to fix CIs error |
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to enable users to download chart (including legend) as an image file.
The image file is generated at frontend as follows.
Generated png image is like: