This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I put quick examples on https://github.com/disktnk/chainerui-demo-20180609/tree/master/vae |
makky3939
approved these changes
Nov 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I tried this p-r using example scripts
gky360
approved these changes
Dec 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙇
ofk
approved these changes
Dec 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides
summary.image
method andsummary.reporter
to visualize images on browser. Current ChainerUI has already provided (undocumented)ImageReporter
, the extension collects images cached bysummary.image
, splitregister
phase andwrite
phase, to reduce file writing cost. In many case, however, registering images and write tend to do in same time such as evaluation time, this design confuses.Usage
x
,x2
are converted as PNG format and show on a browser.out_path
is required to same aslog
file directory.x
andx2
are converted as PNG format and show in same row.Pros
Trainer
Cons
epoch
anditeration
are not set automaticallyout_put
every timeTo deal with Cons. 1,
timestamp
key is added automatically to distinguish images roughly. Additionally any key-pair discription can be set on the function, likesummary.image(x, out_path, epoch=10)
To be ease Cons 2, prepare
chainerui.summary.set_out(out_path)
method to setout_path
once.