Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Default result name #266

Merged
merged 5 commits into from
Apr 18, 2019
Merged

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Mar 1, 2019

If .chainerui_conf file exists and set "default_result_name", get result name from the file and set. Once set the name, result name never update by the file even if the file is updated.

file name: .chainerui_conf
format: JSON
content:
"default_result_name": the name of result name on default.

@disktnk disktnk requested review from makky3939 and ofk March 1, 2019 06:59
@disktnk disktnk changed the title Feature/default result name Default result name Mar 1, 2019
@disktnk disktnk added this to the v0.10.0 milestone Mar 1, 2019
@makky3939
Copy link
Contributor

/api/v1/projects/{p_id}/results will return with 500 when read broken json in .chainerui_conf.

but, It might be better to return with 200 while skipping broken json loading.

@disktnk
Copy link
Member Author

disktnk commented Apr 16, 2019

Thank you for review, I updated the point.

Copy link
Contributor

@makky3939 makky3939 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@makky3939 makky3939 merged commit 87ad25e into chainer:master Apr 18, 2019
@disktnk disktnk deleted the feature/default-result-name branch May 31, 2019 05:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants