Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Add simple filtering UI for experiments table #301

Merged
merged 18 commits into from
Oct 4, 2019

Conversation

gky360
Copy link
Contributor

@gky360 gky360 commented Jun 26, 2019

Enable users to filter out unncessary results.

filter-results

@disktnk disktnk added this to the v0.11.0 milestone Aug 1, 2019
@gky360 gky360 changed the title [WIP] Add simple filtering UI for experiments table Add simple filtering UI for experiments table Sep 26, 2019
@gky360 gky360 requested a review from ofk September 26, 2019 01:47
@@ -39,6 +39,8 @@ export const getRelativeResultPathName = (project = {}, result = {}) =>
export const getGrandParentDirectoryName = (result = {}) =>
path.basename(path.resolve(result.pathName, '..'));

export const getResultGroupName = (result = {}) => getGrandParentDirectoryName(result);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this method an alias?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is just an alias. I'll rename the function and remove the alias.

@ofk ofk merged commit 162ac57 into chainer:master Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants