Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move vanity names to account roles pallet #4719

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

j4m1ef0rd
Copy link
Contributor

Pull Request

Closes: PRO-1255

Checklist

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

  • Moved the vanity name storage item to the account roles pallet.
    • Moved the related benchmark and test.
  • Created a migration. Tested it with try-migration.

@j4m1ef0rd j4m1ef0rd requested a review from msgmaxim April 3, 2024 03:15
@j4m1ef0rd j4m1ef0rd self-assigned this Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 72%. Comparing base (9b4b855) to head (ff9daad).
Report is 3 commits behind head on main.

Files Patch % Lines
state-chain/runtime/src/lib.rs 0% 21 Missing and 4 partials ⚠️
state-chain/pallets/cf-account-roles/src/lib.rs 53% 13 Missing and 1 partial ⚠️
...tate-chain/pallets/cf-account-roles/src/weights.rs 0% 14 Missing ⚠️
api/lib/src/lib.rs 0% 4 Missing ⚠️
state-chain/pallets/cf-account-roles/src/tests.rs 94% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #4719    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        417     418     +1     
  Lines      69532   69447    -85     
  Branches   69532   69447    -85     
======================================
- Hits       50246   50084   -162     
- Misses     16879   16959    +80     
+ Partials    2407    2404     -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen
Copy link
Collaborator

I made some additions and resolved conflicts - let me know what you think .

@j4m1ef0rd j4m1ef0rd requested review from kylezs and removed request for msgmaxim April 5, 2024 03:20
state-chain/pallets/cf-account-roles/src/lib.rs Outdated Show resolved Hide resolved
Co-authored-by: kylezs <kyle@chainflip.io>
@dandanlen dandanlen enabled auto-merge (squash) April 5, 2024 09:11
@dandanlen dandanlen merged commit 7ad9dee into main Apr 5, 2024
43 checks passed
@dandanlen dandanlen deleted the refactor/move-vanity-names branch April 5, 2024 09:40
syan095 added a commit that referenced this pull request Apr 8, 2024
…-validator

* origin/main:
  fix: broker flakiness on bouncer CI (#4736)
  fix: migration for earned fees (#4733)
  feat: handle prewitness deposits (#4698)
  Update Sdk with Arbitrum support (#4720)
  chore: remove insta deprecated warning (#4734)
  refactor: move vanity names to account roles pallet (#4719)
  Arbitrum backup rpc (#4730)

# Conflicts:
#	state-chain/pallets/cf-validator/src/lib.rs
#	state-chain/pallets/cf-validator/src/mock.rs
#	state-chain/pallets/cf-validator/src/tests.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants