Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrum backup rpc #4730

Merged
merged 8 commits into from
Apr 5, 2024
Merged

Arbitrum backup rpc #4730

merged 8 commits into from
Apr 5, 2024

Conversation

albert-llimos
Copy link
Contributor

@albert-llimos albert-llimos commented Apr 4, 2024

Pull Request

Closes: PRO-1226

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

  • Fixed bug in Arbitrum rpc where it wasn't properly parsing the endpoint passed as opts.
  • Added backup rpc.

@albert-llimos albert-llimos changed the title test: add test for main arbitrum rpc Arbitrum backup rpc Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72%. Comparing base (8feefa8) to head (1610fd0).

Files Patch % Lines
engine/src/settings.rs 96% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4730   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        417     417           
  Lines      69387   69430   +43     
  Branches   69387   69430   +43     
=====================================
+ Hits       50044   50085   +41     
- Misses     16932   16936    +4     
+ Partials    2411    2409    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albert-llimos albert-llimos marked this pull request as ready for review April 4, 2024 12:53
@albert-llimos albert-llimos requested a review from a team as a code owner April 4, 2024 12:53
@albert-llimos albert-llimos requested review from ahasna, xtroleum and ramizhasan111 and removed request for a team, ahasna and xtroleum April 4, 2024 12:53
Copy link
Contributor

@kylezs kylezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you should create a PR on the docs repo to add these new settings (but not merge it yet ofc)

charts/chainflip-node/values.yaml Show resolved Hide resolved
@albert-llimos
Copy link
Contributor Author

Also you should create a PR on the docs repo to add these new settings (but not merge it yet ofc)

Just added a linear ticket for that: https://linear.app/chainflip/issue/PRO-1290/arbitrum-rpc-documentation

@albert-llimos albert-llimos enabled auto-merge (squash) April 5, 2024 06:23
@albert-llimos albert-llimos merged commit a6432a1 into main Apr 5, 2024
46 checks passed
@albert-llimos albert-llimos deleted the feat/arbitrum-rpc-backup branch April 5, 2024 06:25
syan095 added a commit that referenced this pull request Apr 8, 2024
…-validator

* origin/main:
  fix: broker flakiness on bouncer CI (#4736)
  fix: migration for earned fees (#4733)
  feat: handle prewitness deposits (#4698)
  Update Sdk with Arbitrum support (#4720)
  chore: remove insta deprecated warning (#4734)
  refactor: move vanity names to account roles pallet (#4719)
  Arbitrum backup rpc (#4730)

# Conflicts:
#	state-chain/pallets/cf-validator/src/lib.rs
#	state-chain/pallets/cf-validator/src/mock.rs
#	state-chain/pallets/cf-validator/src/tests.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants