Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use encoded address for refund_address in events #5135

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

dandanlen
Copy link
Collaborator

@dandanlen dandanlen commented Aug 8, 2024

Pull Request

Closes: PRO-1553

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works. (Waiting for tests to pass)
  • I have written sufficient tests. (updated existing tests)
  • I have written and tested required migrations. (none require)
  • I have updated documentation where appropriate. (nothing required afaict)

Summary

Please include a succinct description of the purpose and content of the PR. What problem does it solve, and how? Link issues, discussions, other PRs, and anything else that will help the reviewer.

See Linear description.

Changes are potentially engine-breaking (event update) which is why it would be good to include this in 1.5.1

@dandanlen dandanlen force-pushed the fix/use-encoded-address-for-refund-params branch 2 times, most recently from 4c6fb4e to 16f32a7 Compare August 8, 2024 15:50
@dandanlen dandanlen changed the title [AUTOMATED] Benchmarking results. fix: use encoded address for refund_address in events Aug 8, 2024
@dandanlen dandanlen marked this pull request as ready for review August 8, 2024 16:32
@dandanlen dandanlen requested a review from a team as a code owner August 8, 2024 16:32
@dandanlen dandanlen requested review from jerryafr and zoheb391 and removed request for a team August 8, 2024 16:32
@dandanlen dandanlen force-pushed the fix/use-encoded-address-for-refund-params branch from 7cd758a to 8d38285 Compare August 8, 2024 16:32
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 60.71429% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (667a10a) to head (8d38285).

Files Patch % Lines
api/lib/src/lib.rs 0% 5 Missing ⚠️
state-chain/pallets/cf-ingress-egress/src/lib.rs 33% 2 Missing ⚠️
...ess-egress/src/migrations/add_broker_fee_to_ccm.rs 0% 2 Missing ⚠️
state-chain/pallets/cf-swapping/src/lib.rs 80% 1 Missing ⚠️
state-chain/traits/src/lib.rs 0% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           release/1.5   #5135   +/-   ##
===========================================
  Coverage           71%     71%           
===========================================
  Files              446     446           
  Lines            77037   77049   +12     
  Branches         77037   77049   +12     
===========================================
+ Hits             54672   54684   +12     
- Misses           19427   19431    +4     
+ Partials          2938    2934    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@syan095 syan095 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm all unit tests pass and all Bouncer tests pass

@kylezs kylezs merged commit d0f687b into release/1.5 Aug 9, 2024
48 checks passed
@kylezs kylezs deleted the fix/use-encoded-address-for-refund-params branch August 9, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants