Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use encoded addresses in refund params for events #5138

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

dandanlen
Copy link
Collaborator

Cherry pick of changes from #5135

@dandanlen dandanlen requested a review from msgmaxim August 9, 2024 08:00
@kylezs kylezs requested a review from jerryafr August 12, 2024 09:24
@dandanlen dandanlen force-pushed the fix/use-encoded-addresses-in-refund-params branch from 99f7893 to 6d21557 Compare August 14, 2024 14:58
@dandanlen dandanlen force-pushed the fix/use-encoded-addresses-in-refund-params branch from 6d21557 to 0893760 Compare August 14, 2024 15:20
@dandanlen
Copy link
Collaborator Author

Fixed compiler issues / clippy.

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (a716d50) to head (0893760).
Report is 1 commits behind head on main.

Files Patch % Lines
api/lib/src/lib.rs 0% 5 Missing ⚠️
state-chain/pallets/cf-ingress-egress/src/lib.rs 33% 2 Missing ⚠️
state-chain/pallets/cf-swapping/src/lib.rs 75% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5138    +/-   ##
======================================
- Coverage     71%     71%    -0%     
======================================
  Files        460     460            
  Lines      81919   81787   -132     
  Branches   81919   81787   -132     
======================================
- Hits       58422   58233   -189     
- Misses     20404   20461    +57     
  Partials    3093    3093            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen dandanlen added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit ecf4c58 Aug 14, 2024
48 checks passed
@dandanlen dandanlen deleted the fix/use-encoded-addresses-in-refund-params branch August 14, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants