feat: use encoded address in ccm deposit metadata in events #5192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5192 +/- ##
======================================
- Coverage 70% 70% -0%
======================================
Files 481 481
Lines 86087 85969 -118
Branches 86087 85969 -118
======================================
- Hits 60399 60224 -175
- Misses 22419 22475 +56
- Partials 3269 3270 +1 ☔ View full report in Codecov by Sentry. |
msgmaxim
reviewed
Aug 23, 2024
| @@ -1966,7 +1966,14 @@ pub mod pallet { | |||
| output_address: T::AddressConverter::to_encoded_address( | |||
| output_address.clone(), | |||
| ), | |||
| ccm_deposit_metadata: ccm_deposit_metadata.clone(), | |||
| ccm_deposit_metadata: cf_chains::CcmDepositMetadataEncoded { | |||
There was a problem hiding this comment.
I think CcmDepositMetadata is also exposed via the CcmFailed event, so that one should be updated to use the encoded version.
| @@ -688,6 +688,14 @@ mod ccm { | |||
| #[track_caller] | |||
| fn init_ccm_swap_request(input_asset: Asset, output_asset: Asset, input_amount: AssetAmount) { | |||
| let ccm_deposit_metadata = generate_ccm_deposit(); | |||
| let ccm_deposit_metadata_encoded = cf_chains::CcmDepositMetadataEncoded { | |||
There was a problem hiding this comment.
We could have a method on CcmDepositMetadata to convert it into the encoded verson (taking AddressConverter as a generic parameter?). Or you can look at how it is done for ChannelRefundParametersGeneric.
j4m1ef0rd
changed the title
* feat: add fok and dca params to SwapRequested event * chore: test dca and fok parameters are in event
dandanlen
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1597
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Made
CcmDepositMetadatageneric so we can encode the address inside of it when outputting it in the swap requested event and the ccm failed event.