feat: add fok and dca params to SwapRequested event #5193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j4m1ef0rd
reviewed
Aug 23, 2024
msgmaxim
force-pushed
the
dca-fok-params-in-swap-requested-event
branch
from
957096f
to
863b5f7
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
* feat: use encoded address in ccm deposit metadata for swap requested event * refactor: address PR comments * feat: add fok and dca params to SwapRequested event (#5193) * feat: add fok and dca params to SwapRequested event * chore: test dca and fok parameters are in event * refactor: use impl instead of utility function --------- Co-authored-by: Maxim Shishmarev <msgmaxim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Note: Targeting other swapping event PR to avoid conflicts.
Closes: PRO-1549
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
As dicussed (a while back), adding these parameters to
SwapRequested.