fix: submit eip1559 transactions

[kylezs]

Pull Request

Closes: PRO-821

Checklist

Please conduct a thorough self-review before opening the PR.

• I am confident that the code works.
• I have updated documentation where appropriate.

Summary

The .into() wasn't acting as expected, it converted it to the general typed transaction type, but that was treated as a Legacy tx 🤷‍♂️ . Making it explicit is the solution :)

[linear]

PRO-821 CFEs broadcast ethereum TX's of legacy type

The CFEs seem to be broadcasting transactions of type 0 (Legacy) instead of the new type2 transactions after EIP-1559. This means our gas calculations are off, especially for CCM swaps, and we are definitely overpaying for all the transactions.

Here is an example:

https://goerli.etherscan.io/tx/0xcd5252c93ace7c3fc67821f36e034004d034621293516c7ed97e9a281ebe35e1

We should instead broadcast transactions of type 2.

[codecov]

Codecov Report

Merging #3973 (4ffeb6e) into main (50beb8f) will increase coverage by 0%.
Report is 2 commits behind head on main.
The diff coverage is 0%.

@@          Coverage Diff          @@
##            main   #3973   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        366     366           
  Lines      56791   56827   +36     
  Branches   56791   56827   +36     
=====================================
+ Hits       40951   40994   +43     
+ Misses     13754   13749    -5     
+ Partials    2086    2084    -2     

Files Changed	Coverage Δ
engine/src/eth/retry_rpc.rs	7% <0%> (ø)
engine/src/eth/rpc.rs	0% <0%> (ø)

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.