Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-add version update #4533

Merged
merged 2 commits into from
Feb 14, 2024
Merged

fix: re-add version update #4533

merged 2 commits into from
Feb 14, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Feb 14, 2024

This was erroneously removed in #4478 . I'm adding it back here.

@kylezs kylezs requested a review from dandanlen as a code owner February 14, 2024 15:33
@kylezs kylezs requested a review from syan095 February 14, 2024 15:33
@kylezs kylezs changed the title Fix/add version update fix: re-add version update Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b11cde) 73% compared to head (0ea845d) 73%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4533   +/-   ##
=====================================
- Coverage     73%     73%   -0%     
=====================================
  Files        401     401           
  Lines      68125   68128    +3     
  Branches   68125   68128    +3     
=====================================
- Hits       49474   49471    -3     
- Misses     15991   15994    +3     
- Partials    2660    2663    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen dandanlen merged commit 003ba3d into main Feb 14, 2024
43 checks passed
@dandanlen dandanlen deleted the fix/add-version-update branch February 14, 2024 16:22
syan095 added a commit that referenced this pull request Feb 16, 2024
…igned-error

* origin/main:
  chore: fetch solana state from docker (#4538)
  feat: charge a fee for opening swap deposit addresses (#4512)
  refactor: Remove RpcAsset (PRO-1187) (#4491)
  fix: re-add version update (#4533)
  fix: pull first (#4526)
  feat: auto pick non-breaking changes (#4498)

# Conflicts:
#	state-chain/pallets/cf-ingress-egress/src/lib.rs
#	state-chain/pallets/cf-ingress-egress/src/tests.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants