Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable try-state checks #4576

Merged
merged 2 commits into from
Feb 28, 2024
Merged

fix: disable try-state checks #4576

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8617340
fix: disable try-state checks
dandanlen Feb 27, 2024
b32f333
chore: comment
dandanlen Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bouncer/shared/try_runtime_upgrade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ function tryRuntimeCommand(runtimePath: string, blockParam: string, networkUrl:
const stderrFile = path.join(os.tmpdir(), `cmd-stderr-${Date.now()}`);
try {
execSync(
`try-runtime --runtime ${runtimePath} on-runtime-upgrade --disable-spec-version-check --disable-idempotency-checks --checks all ${blockParam} --uri ${networkUrl} 2> ${stderrFile}`,
`try-runtime --runtime ${runtimePath} on-runtime-upgrade --disable-spec-version-check --disable-idempotency-checks --checks pre-and-post ${blockParam} --uri ${networkUrl} 2> ${stderrFile}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we drop a TODO with a link to the issue here too

{ env: { ...process.env, RUST_LOG: 'runtime::executive=debug' } },
);
console.log(`try-runtime success for blockParam ${blockParam}`);
Expand Down
Loading