Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debug cli #4605

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix: debug cli #4605

merged 1 commit into from
Mar 5, 2024

Conversation

marcellorigotti
Copy link
Contributor

@marcellorigotti marcellorigotti commented Mar 5, 2024

Pull Request

Closes: PRO-1156

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

CLI wasn't working in debug mode, removing the version_short fixed the problem

The version command can now be called with: --version or -V
If we want -v instead I can add

#[cfg(not(debug_assertions))]
#[clap(version = env!("SUBSTRATE_CLI_IMPL_VERSION"), version_short = 'v')]
pub struct CLICommandLineOptions { ... }

such that when we compile with --release flag enabled we can use -v

Non-Breaking changes

@marcellorigotti marcellorigotti added the non-breaking Merging this PR will create a cherry-pick onto release label Mar 5, 2024
@marcellorigotti marcellorigotti requested a review from kylezs March 5, 2024 10:32
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72%. Comparing base (b25e4b0) to head (0f28e17).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4605   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        401     401           
  Lines      66787   66787           
  Branches   66787   66787           
=====================================
+ Hits       48412   48415    +3     
- Misses     16026   16028    +2     
+ Partials    2349    2344    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs kylezs merged commit 84431d3 into main Mar 5, 2024
43 checks passed
@kylezs kylezs deleted the feature/pro-1156 branch March 5, 2024 15:43
@kylezs
Copy link
Contributor

kylezs commented Mar 5, 2024

Thanks 🙏

chainflip-bot pushed a commit that referenced this pull request Mar 5, 2024
fix cli in debug mode

(cherry picked from commit 84431d3)
syan095 added a commit that referenced this pull request Mar 7, 2024
…ncoding

* origin/main: (21 commits)
  chore: update chainspecs (#4615)
  feat: Add channel opening fee to *DepositAddressReady Events (#4609)
  refactor: pass out CFE incompatibility exit information to main (#4563)
  feat: Introduce tx fee multiplier storage item (#4594)
  fix: debug cli  (#4605)
  fix: patch 1.2 broker test (#4607)
  feat: add block height and deposit details to PrewitnessedDeposit (#4606)
  chore: add myself as codeowner to upgrade-test (#4603)
  fix: RUSTSEC-2024-0019 (#4604)
  fix: upgrade test pnpm install from commit (#4600)
  chore: add notification on failed release build (#4589)
  chore: add Zellic audit to Security.md (#4599)
  update changelog for 1.2.1 (#4597)
  fix: use correct pnpm deps for upgrade-test (#4596)
  chore(bouncer): Use stable sdk version (#4595)
  chore(bouncer): Update sdk to 1.2.1 (#4582)
  log meaningful message if docker login fails (#4553)
  Added bouncer command to download a runtime update from a proposal (#4592)
  chore: add asset to withdrawal event (#4590)
  ingress-egress-tracker: add tx_ref to redis (#4573)
  ...

# Conflicts:
#	state-chain/runtime/src/lib.rs
syan095 added a commit that referenced this pull request Mar 10, 2024
…utxo

* origin/main:
  fix "get_proposed_runtime" command (#4624)
  fix: allow OldAsset to support unambiguously encoding Arb USDC and Eth USDC, while maintaining backcompat (PRO-1237) (#4614)
  fix: start localnet using correct commit (#4623)
  chore: migration housekeeping (#4612)
  feat: add arbitrum support (PRO-1154) (#4486)
  fix: swap subscription amounts as hex (#4611)
  feat: use swapping queue when swapping network fee for burn (#4584)
  chore: update chainspecs (#4615)
  feat: Add channel opening fee to *DepositAddressReady Events (#4609)
  refactor: pass out CFE incompatibility exit information to main (#4563)
  feat: Introduce tx fee multiplier storage item (#4594)
  fix: debug cli  (#4605)
  fix: patch 1.2 broker test (#4607)
  feat: add block height and deposit details to PrewitnessedDeposit (#4606)
  chore: add myself as codeowner to upgrade-test (#4603)
  fix: RUSTSEC-2024-0019 (#4604)

# Conflicts:
#	state-chain/pallets/cf-environment/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-breaking Merging this PR will create a cherry-pick onto release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants