feat: write snapshot if try runtime check fails #4657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4657 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 409 411 +2
Lines 70092 70144 +52
Branches 70092 70144 +52
======================================
- Hits 50807 50740 -67
- Misses 16855 16970 +115
- Partials 2430 2434 +4 ☔ View full report in Codecov by Sentry. |
dandanlen
force-pushed
the
feat/write-snapshot-on-try-runtime-failure
branch
3 times, most recently
from
828d7db
to
56943bf
Compare
dandanlen
force-pushed
the
feat/write-snapshot-on-try-runtime-failure
branch
2 times, most recently
from
8792c87
to
6560448
Compare
dandanlen
force-pushed
the
feat/write-snapshot-on-try-runtime-failure
branch
2 times, most recently
from
221aa10
to
330016d
Compare
dandanlen
force-pushed
the
feat/write-snapshot-on-try-runtime-failure
branch
from
3844ac3
to
b47363a
Compare
dandanlen
commented
Apr 11, 2024
| const stderrOutput = fs.readFileSync(stderrFile, 'utf8'); | ||
| console.error(e); | ||
| console.error('Command failed: Command output:', stderrOutput); | ||
| function createSnapshotFile(networkUrl: string, blockHash: string) { |
| ); | ||
| } | ||
|
|
||
| function tryRuntimeCommand(runtimePath: string, blockHash: 'latest' | string, networkUrl: string) { |
There was a problem hiding this comment.
This is just refactored to use execWithRustLog and write a snapshot if it fails.
kylezs
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restructures some of the try-runtime tests and adds some utilities (see comments).
My main motivation for this was to write snapshots of failed runtime upgrade blocks so these can be downloaded for local debugging when something fails.
After trying for a long time to get nodeJS/github actions to output stderr to be able to read the try-runtime log, I finally gave but. But then I realised (quite late) that the try-runtime output is already visible in the chainflip-node logs! So I just added a notice to that effect when the try-runtime tests exit with an error.