Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/PRO-1161/restructure-cf-pool-events #4718

Draft
wants to merge 9 commits into
base: epic/lp-api-refactors
Choose a base branch
from

Conversation

Janislav
Copy link
Contributor

@Janislav Janislav commented Apr 2, 2024

Pull Request

Closes: PRO-1161

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Replaces the usage of base/quote asset with AssetPair in events, extrinsics and RPCs.

Non-Breaking changes

Pretty sure thats a breaking change.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 81.57895% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 72%. Comparing base (95abec1) to head (0752055).

❗ Current head 0752055 differs from pull request most recent head 7ccbbb4. Consider uploading reports for the commit 7ccbbb4 to get more accurate results

Files Patch % Lines
api/lib/src/lp.rs 0% 14 Missing ⚠️
state-chain/pallets/cf-pools/src/lib.rs 71% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           epic/lp-api-refactors   #4718    +/-   ##
======================================================
- Coverage                     72%     72%    -0%     
======================================================
  Files                        409     409            
  Lines                      70101   69850   -251     
  Branches                   70101   69850   -251     
======================================================
- Hits                       50810   50529   -281     
- Misses                     16864   16899    +35     
+ Partials                    2427    2422     -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Janislav Janislav changed the base branch from main to epic/lp-api-refactors April 9, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant