-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor/improve-rpc-encode-decode #4737
base: main
Are you sure you want to change the base?
Conversation
Removed all usage of NumberOrHex from the LP inclusive all types that are relying on NumberOrHex. Removed all usage of NumberOrHex from the LP inclusive all types that are relying on NumberOrHex. Replaced it with a generic functions that takes a U256 and tries to parse it to the type of the generic argument.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4737 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 412 412
Lines 70705 70580 -125
Branches 70705 70580 -125
======================================
- Hits 51140 50931 -209
- Misses 17071 17146 +75
- Partials 2494 2503 +9 ☔ View full report in Codecov by Sentry. |
Not sure if this is important to you PR or not, but just FYI, there is a custom implementation for |
As discussed, putting this here into draft for now @AlastairHolmes. |
Pull Request
Closes: PRO-1157
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Non-Breaking changes
In theory, that should be non-breaking. It still needs some more further checking to ensure that, though. We assume that because NumberOrHex can theoretically decode to a hex string, so LPs also have to handle that case already, which means replacing that with a type that always returns as hex should be none-breaking. Apart from that, during the transition over the next version, we keep the old API as it is and give LPs time to change their implementation. With an upcoming version, we will remove this old API.