test: snapshot testing for new rpcs #4792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msgmaxim
force-pushed
the
test/boost-rpc-snapshot
branch
from
cc5688e
to
bb4aa42
Compare
dandanlen
reviewed
Apr 23, 2024
| "asset": "FLIP" | ||
| }, | ||
| "tier": 10, | ||
| "available_amount": 1000000000000000000000000000000000000 |
There was a problem hiding this comment.
Should we not serialize amounts using hex? ( @GabrielBuragev ?)
There was a problem hiding this comment.
Yeah, was thinking about that too as I was writing this test. Don't think JS will be able to read this number accurately. I thought if the PRs are merged quickly, I'd make the change in a separate PR (since the PR for the other RPC method is already merged anyway), but since there are some other comments to address anyway, I will update it to use the hex amounts too.
2 tasks
|
Closing this as now I've added these tests directly in #4780 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1336
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Added snapshot tests for the boost RPCs.
I also used
assert_json_snapshot, which seems to work better thanassert_snapshotwith converting to JSON manually used for other RPCs (it also pretty-prints, which means on conflict you will see its precise location because serialization is no longer a single line).Note that this is on top of the other open PR (if both are approved at the same time, it might be easier to merge this one first).