SCC Dynamic Events #5037
Draft
SCC Dynamic Events #5037
+640
−532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandanlen
force-pushed
the
feat/dynamic-events-rpc
branch
from
602e798
to
a19d5fe
Compare
dandanlen
force-pushed
the
feat/scc-dynamic-events
branch
from
d2a1f60
to
8407891
Compare
dandanlen
force-pushed
the
feat/scc-dynamic-events
branch
from
8407891
to
7410e24
Compare
dandanlen
force-pushed
the
feat/dynamic-events-rpc
branch
from
a19d5fe
to
4334afb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1246
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Adds the dynamic events rpc to the SCC and uses this for determining extrinsic success.
Events are returned as JSON, with DynamicEvent utility wrappers to give some extra safety.
There are some other utilities for consuming/converting the dynamic event data in the lp and broker apis, in an attempt to keep the same apis as we have currently.
Ideally, at some point the Events/JSON will already contain the correctly-encoded values and can be passed through more-or-less without modification.
I haven't had time to test this yet, i'm confident there will be issues.