-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the ability to close all open orders #5038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change extrinsic to close_batch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5038 +/- ##
=======================================
- Coverage 71% 70% -1%
=======================================
Files 458 481 +23
Lines 82125 86159 +4034
Branches 82125 86159 +4034
=======================================
+ Hits 58138 60341 +2203
- Misses 20917 22534 +1617
- Partials 3070 3284 +214 ☔ View full report in Codecov by Sentry. |
dandanlen
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1471
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Added
cancel_orders_batch
extrinsic to allow lp to close multiple orders at the same time (up to 100)Added
cancel_orders_batch
andcancel_all_orders
to the LP API, the latter simply query for all the open orders and then submit acancel_orders_batch
, in case the open orders are more than 100 it will submit multiple extrinsics with batch of 100 orders each (if the WaitFor parameter is set to InBlock or Finalized the extrinsics will be split across multiple blocks)The events emitted are the same as before (RangeOrderUpdated, LimitOrderUpdated), there will be one event for each order being closed, in case an order passed is not correct (wrong orderId or the order was fully filled before the extrinsic is executed) the deletion of that order is skipped and a new event
OrderDeletionFailed { order: CloseOrder }
is emitted.Breaking changes
New extrinsic and event added