chore: unblock 1.5 release by releasing 1.4.6 🥴 #5073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahasna
requested review from
jerryafr,
GabrielBuragev and
kylezs
and removed request for
a team,
dandanlen,
jerryafr and
GabrielBuragev
ahasna
commented
Jul 23, 2024
| @@ -11,7 +11,7 @@ pub mod build_helpers; | |||
| // relevant crates. | |||
| // Should also check that the compatibility function below `args_compatible_with_old` is correct. | |||
| pub const OLD_VERSION: &str = "1.3.5"; | |||
| pub const NEW_VERSION: &str = "1.4.5"; | |||
| pub const NEW_VERSION: &str = "1.4.6"; | |||
There was a problem hiding this comment.
@kylezs I believe this means we have to use this new version on release/1.5, correct?
There was a problem hiding this comment.
Yeah exactly, 1.4.6 would be the "old version" on 1.5
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/1.4 #5073 +/- ##
===========================================
- Coverage 72% 72% -0%
===========================================
Files 424 424
Lines 73524 73524
Branches 73524 73524
===========================================
- Hits 52743 52741 -2
- Misses 18143 18144 +1
- Partials 2638 2639 +1 ☔ View full report in Codecov by Sentry. |
kylezs
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.