Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow unswept funds to be used in boost #5164

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Aug 19, 2024

Pull Request

Closes: PRO-1547

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Figured this was easy enough to get in before 1.6.

@kylezs kylezs requested a review from msgmaxim August 19, 2024 08:14
@kylezs kylezs requested a review from dandanlen as a code owner August 19, 2024 08:14
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (6ec3507) to head (ecd3177).
Report is 1 commits behind head on main.

Files Patch % Lines
state-chain/pallets/cf-ingress-egress/src/lib.rs 0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5164    +/-   ##
======================================
- Coverage     71%     71%    -0%     
======================================
  Files        458     458            
  Lines      82135   81992   -143     
  Branches   82135   81992   -143     
======================================
- Hits       58145   57941   -204     
- Misses     20920   20974    +54     
- Partials    3070    3077     +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dandanlen dandanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably conflict with #5083 - would suggest adding it after that / branching off that PR.

state-chain/pallets/cf-ingress-egress/src/lib.rs Outdated Show resolved Hide resolved
@dandanlen dandanlen force-pushed the fix/allow-use-of-unswept-balance-for-boost branch from b8968dd to ecd3177 Compare August 20, 2024 12:11
@dandanlen dandanlen added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2024
@dandanlen dandanlen added this pull request to the merge queue Aug 20, 2024
@dandanlen
Copy link
Collaborator

(I rebased against main)

Merged via the queue into main with commit 5902020 Aug 20, 2024
48 checks passed
@dandanlen dandanlen deleted the fix/allow-use-of-unswept-balance-for-boost branch August 20, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants