Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/PRO-1581/delta-based-ingress #5227

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Janislav
Copy link
Contributor

@Janislav Janislav commented Sep 3, 2024

Pull Request

Closes: PRO-1581

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Please include a succinct description of the purpose and content of the PR. What problem does it solve, and how? Link issues, discussions, other PRs, and anything else that will help the reviewer.

Non-Breaking changes

If this PR includes non-breaking changes, select the non-breaking label. On merge, CI will automatically cherry-pick the commit to a PR against the release branch.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 82.85714% with 18 lines in your changes missing coverage. Please review.

Project coverage is 70%. Comparing base (b8f1667) to head (7e41569).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...lectoral_systems/blockchain/delta_based_ingress.rs 83% 18 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5227   +/-   ##
=====================================
- Coverage     70%     70%   -0%     
=====================================
  Files        481     483    +2     
  Lines      86382   86345   -37     
  Branches   86382   86345   -37     
=====================================
- Hits       60608   60582   -26     
+ Misses     22490   22476   -14     
- Partials    3284    3287    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen dandanlen force-pushed the tests/pro-1581/delta-based-ingress branch from 4dea099 to 9ce1664 Compare September 11, 2024 08:30
@dandanlen dandanlen changed the base branch from main to tests/electoral-systems September 11, 2024 08:31
@dandanlen dandanlen force-pushed the tests/pro-1581/delta-based-ingress branch from 9ce1664 to 035a83f Compare September 12, 2024 09:35
Base automatically changed from tests/electoral-systems to main September 12, 2024 14:02
@dandanlen dandanlen force-pushed the tests/pro-1581/delta-based-ingress branch from 035a83f to 8affa33 Compare September 12, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant