Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace egress witnessing with change witnesser. #5252

Closed
wants to merge 1 commit into from

Conversation

dandanlen
Copy link
Collaborator

Pull Request

Closes: PRO-1655

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works. (Gonna wait until bouncer)
  • I have written sufficient tests. (Tests are coming in other PRs)
  • I have written and tested required migrations. (TODO)
  • I have updated documentation where appropriate.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 70%. Comparing base (f4dd3db) to head (8c84438).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
...te-chain/runtime/src/chainflip/solana_elections.rs 36% 8 Missing and 1 partial ⚠️
engine/src/witness/sol.rs 0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5252    +/-   ##
======================================
- Coverage     70%     70%    -0%     
======================================
  Files        486     485     -1     
  Lines      87289   87105   -184     
  Branches   87289   87105   -184     
======================================
- Hits       61298   61070   -228     
- Misses     22695   22733    +38     
- Partials    3296    3302     +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen dandanlen mentioned this pull request Sep 10, 2024
4 tasks
@kylezs
Copy link
Contributor

kylezs commented Sep 20, 2024

Closing as discussed.

@kylezs kylezs closed this Sep 20, 2024
@kylezs kylezs deleted the fix/use-change-for-egress-witnessing branch September 20, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants