Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/scale types for pending ceremonies #5286

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

martin-chainflip
Copy link
Contributor

Pull Request

Closes: PRO-1676

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

This change renames the types returned by the ThresholdSignature -> pendingCeremonies call so that different types have different names.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70%. Comparing base (a17fd16) to head (2134920).

Files with missing lines Patch % Lines
...te-chain/pallets/cf-threshold-signature/src/lib.rs 94% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5286    +/-   ##
======================================
- Coverage     70%     70%    -0%     
======================================
  Files        487     487            
  Lines      87295   87182   -113     
  Branches   87295   87182   -113     
======================================
- Hits       61312   61141   -171     
- Misses     22703   22759    +56     
- Partials    3280    3282     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant