Wrap context-aware handlers + values around loggers by default. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we didn't allowed you to provide any handler you wanted, which didn't quite meet expectations for using clog. This changes the behavior to always wrap the logger with a context handler. Additionally, when a new logger is created any values present in the context are added to the logger, which should allow the values to be preserved even if the default slog funcs are used.
jonjohnsonjr
approved these changes
Jan 23, 2025
imjasonh
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we didn't allowed you to provide any handler you wanted, which didn't quite meet expectations for using clog. This changes the behavior to always wrap the logger with a context handler.
Additionally, when a new logger is created any values present in the context are added to the logger, which should allow the values to be preserved even if the default slog funcs are used.