Split up the ddos_refs rule for improved accuracy #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egibs
approved these changes
Jul 2, 2024
Co-authored-by: Evan Gibler <20933572+egibs@users.noreply.github.com> Signed-off-by: Thomas Strömberg <t@chainguard.dev>
|
Closes: #289 |
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Aug 5, 2024
* Split up the ddos rule for better accuracy * Split up the ddos rule for better accuracy * Add testdata * remove hashes that will no longer match * simplify condition * spaces, not tabs * Update rules/net/ddos.yara Co-authored-by: Evan Gibler <20933572+egibs@users.noreply.github.com> Signed-off-by: Thomas Strömberg <t@chainguard.dev> --------- Signed-off-by: Thomas Strömberg <t@chainguard.dev> Co-authored-by: Evan Gibler <20933572+egibs@users.noreply.github.com>
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Sep 25, 2024
* Split up the ddos rule for better accuracy * Split up the ddos rule for better accuracy * Add testdata * remove hashes that will no longer match * simplify condition * spaces, not tabs * Update rules/net/ddos.yara Co-authored-by: Evan Gibler <20933572+egibs@users.noreply.github.com> Signed-off-by: Thomas Strömberg <t@chainguard.dev> --------- Signed-off-by: Thomas Strömberg <t@chainguard.dev> Co-authored-by: Evan Gibler <20933572+egibs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, merely mentioning
synfloodis only a medium, not a critical.While we solved datadog, I encountered other software packages that mentioned
synfloodin a healthy way, so I've split the queries up so that it's unlikely to have a critical hit any longer.