Address false positives for Chromium, KOTS, and Nuclei #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egibs
changed the title
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
commented
Jul 17, 2024
| @@ -24,6 +24,13 @@ rule crypto_stealer : critical { | |||
| $w_trezor = "Trezor" | |||
| $w_exodus = "Exodus" | |||
| $w_coinomi = "Coinomi" | |||
| $not_cats = /\"cats\": \[[^]]{0,64}/ | |||
There was a problem hiding this comment.
This isn't an exhaustive representation of the Wapalyzer schema but these strings should be broad enough to match content from those technology files.
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
9 tasks
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Aug 5, 2024
…v#368) * Address false positives for Chromium, KOTS, and Nuclei * Add additional Chromium string Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * Sort Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * More specific string for kots Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * Chromium rule parity Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> --------- Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Sep 25, 2024
…v#368) * Address false positives for Chromium, KOTS, and Nuclei * Add additional Chromium string Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * Sort Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * More specific string for kots Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * Chromium rule parity Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> --------- Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses critical false positives seen here:
Notes:
ChromestringsI used slightly more specific strings when ignoring the Nuclei false positives since they were originating from JSON content and I wanted to match the exact fields rather than doing something like
$not_description = "\"description\": \"".