Address false positives for SQLPad and Lerna #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
hectorj2f
approved these changes
Jul 22, 2024
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Added samples in |
9 tasks
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Aug 5, 2024
* Address false positives for SQLPad and Lerna Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * Add samples for Lerna and SQLPad Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> --------- Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Sep 25, 2024
* Address false positives for SQLPad and Lerna Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * Add samples for Lerna and SQLPad Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> --------- Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses false positives seen here:
The main issue was the
base64_python_functionsrule triggering on TypeScript code so I added several common JS strings that we can ignore which cleared up the match strings.The other critical was a third-party rule which was matching all three of these strings for a WASM runtime file (
/usr/local/lib/node_modules/lerna/node_modules/@napi-rs/wasm-runtime/dist/runtime.js):