Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address false positives for remaining public packages #378

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

egibs
Copy link
Member

@egibs egibs commented Jul 24, 2024

This PR addresses false positives seen with the following packages:

  • caddy
  • datadog-agent
  • opa
  • php
  • rstudio
  • sonarqube
  • varnish

I also added samples where possible so that we have something to test against.

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
@egibs egibs requested review from tstromberg and hectorj2f July 24, 2024 21:21
egibs added 2 commits July 24, 2024 16:29
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
@egibs
Copy link
Member Author

egibs commented Jul 24, 2024

Just saw a false positive for opa show up so I'll roll that into this PR as well.

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
@egibs
Copy link
Member Author

egibs commented Jul 24, 2024

We have a full public package scan running right now so I'll wait for that to finish before merging this in case anything else shows up.

@egibs egibs changed the title Address false positives for caddy and datadog-agent Address false positives for remaining public packages Jul 25, 2024
@egibs egibs merged commit 15d92ab into chainguard-dev:main Jul 25, 2024
6 checks passed
@egibs egibs deleted the 20240724-false-positives branch July 25, 2024 12:42
@egibs
Copy link
Member Author

egibs commented Jul 29, 2024

Closes: #309

egibs added a commit to egibs/malcontent that referenced this pull request Aug 5, 2024
…#378)

* Address false positives for caddy and datadog-agent

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>

* Fix OCI test

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>

* Automate OCI sample data refresh

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>

* Address opa false positive

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>

* Address false positives and add samples for P-Z packages

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>

---------

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs added a commit to egibs/malcontent that referenced this pull request Sep 25, 2024
…#378)

* Address false positives for caddy and datadog-agent

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>

* Fix OCI test

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>

* Automate OCI sample data refresh

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>

* Address opa false positive

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>

* Address false positives and add samples for P-Z packages

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>

---------

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants