-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address false positives for remaining public packages #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
hectorj2f
approved these changes
Jul 24, 2024
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Just saw a false positive for |
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
hectorj2f
approved these changes
Jul 24, 2024
We have a full public package scan running right now so I'll wait for that to finish before merging this in case anything else shows up. |
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
changed the title
Address false positives for caddy and datadog-agent
Address false positives for remaining public packages
Jul 25, 2024
This was referenced Jul 25, 2024
Closes: #309 |
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Aug 5, 2024
…#378) * Address false positives for caddy and datadog-agent Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * Fix OCI test Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * Automate OCI sample data refresh Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * Address opa false positive Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * Address false positives and add samples for P-Z packages Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> --------- Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Sep 25, 2024
…#378) * Address false positives for caddy and datadog-agent Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * Fix OCI test Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * Automate OCI sample data refresh Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * Address opa false positive Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * Address false positives and add samples for P-Z packages Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> --------- Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses false positives seen with the following packages:
caddy
datadog-agent
opa
php
rstudio
sonarqube
varnish
I also added samples where possible so that we have something to test against.