Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address false positives for mlflow and pytorch #387

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

egibs
Copy link
Member

@egibs egibs commented Jul 30, 2024

This PR addresses false positives with mlflow and pytorch --

  • We already had an exclusion for mlflow but it was a little too specific and didn't account for newer versions
  • Pytorch installs the functorch package which uses magic_trace.py which runs a chmod +x on the magic trace cache location

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
@egibs egibs requested a review from hectorj2f July 30, 2024 12:27
@hectorj2f
Copy link
Member

I wonder if we could add some tests for these.

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
@egibs egibs requested a review from hectorj2f July 30, 2024 12:44
Copy link
Member

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@egibs egibs merged commit 0ad9320 into chainguard-dev:main Jul 30, 2024
6 checks passed
@egibs egibs deleted the 20240730-false-positives branch July 30, 2024 12:56
egibs added a commit to egibs/malcontent that referenced this pull request Aug 5, 2024
* Address false positives for mlflow and pytorch

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>

* Add samples

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>

---------

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs added a commit to egibs/malcontent that referenced this pull request Sep 25, 2024
* Address false positives for mlflow and pytorch

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>

* Add samples

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>

---------

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants