Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address false positives with google-cloud-sdk #388

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

egibs
Copy link
Member

@egibs egibs commented Jul 30, 2024

Closes: #291

This PR addresses all of the false positives outlined in the aforementioned issue and adds samples for increased coverage.

We weren't getting automated PRs in wolfi-dev/os so bincapz wasn't automatically blocking PRs.

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
@egibs egibs requested a review from hectorj2f July 30, 2024 13:58
@egibs egibs merged commit 29dd374 into chainguard-dev:main Jul 30, 2024
6 checks passed
@egibs egibs deleted the address-gcloud-false-positives branch July 30, 2024 14:03
egibs added a commit to egibs/malcontent that referenced this pull request Aug 5, 2024
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs added a commit to egibs/malcontent that referenced this pull request Sep 25, 2024
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

probable false: combo/backdoor/py_setuptools & combo/backdoor/remote_eval in google-cloud-sdk-469
2 participants