Address Kibana false positives #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
commented
Jul 30, 2024
| @@ -116,8 +116,13 @@ rule php_eval_gzinflate_base64_backdoor : critical { | |||
| $f_gzinflate = "gzinflate(" | |||
| $f_base64_decode = "base64_decode" | |||
|
|
|||
| $not_php = "PHP_FLOAT_DIG" fullword | |||
| $not_js = " ?? " | |||
There was a problem hiding this comment.
We also do this for the base64_python_functions rule where JS code was being evaluated in the context of Python code.
egibs
commented
Jul 30, 2024
| } | ||
|
|
||
| rule find_generic_password : high { | ||
| meta: | ||
| description = "Looks up a password from the Keychain" | ||
| strings: | ||
| $ref = /find-generic-passsword[ \-\w\']{0,32}/ | ||
| $ctkcard = "/System/Library/Frameworks/CryptoTokenKit.framework/ctkcard" | ||
| $not_ctkcard = "/System/Library/Frameworks/CryptoTokenKit.framework/ctkcard" | ||
| $not_elastic_author = { 22 61 75 74 68 6F 72 22 3A 20 5B 0A 20 20 20 20 22 45 6C 61 73 74 69 63 22 0A 20 20 5D } |
hectorj2f
approved these changes
Jul 30, 2024
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Aug 5, 2024
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
9 tasks
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Sep 25, 2024
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the false positives seen here.
Most of the false positives were from a third-party rule and two were from our rules. One of the latter failures was due to JavaScript code failing a PHP rule and the other was failing due to the strings matching a Kibana security rule.
I've added both of the latter two findings as samples for better coverage.