Fix sort performance bug #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
tstromberg
approved these changes
Aug 20, 2024
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Sep 25, 2024
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #371
I noticed that our concurrent scan of the Keycloak package (~185,000) files was taking about 2-3 minutes longer with concurrency than it had originally without any concurrency.
I didn't catch this in the concurrency PR, but we're sorting the
pathKeysslice each timeresults.Rangeiterates over theresultsmap. This really adds up when scanning hundreds of thousands of files and explains why we didn't catch the bug in our current samples.This PR sorts the
pathKeysslice after we're done iterating and also removes the unnecessary anonymous function inside of theRangefunction.