Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Wolfi false positve overrides #540

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

egibs
Copy link
Member

@egibs egibs commented Oct 24, 2024

This PR addresses the remaining critical false positives for Wolfi packages with the exception of frp and sqlmap.

I tried to keep the strings for each override generic enough and added filesize guards to each of the new overrides.

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
@egibs egibs requested a review from tstromberg October 24, 2024 16:59
egibs added 2 commits October 24, 2024 12:02
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Copy link
Collaborator

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think there is a general theme here for follow-ups: infection_killer and lvt need to be made stricter.

@egibs
Copy link
Member Author

egibs commented Oct 24, 2024

LGTM. I think there is a general theme here for follow-ups: infection_killer and lvt need to be made stricter.

Agreed 🙂

@egibs egibs merged commit 6ef18f9 into chainguard-dev:main Oct 24, 2024
7 checks passed
@egibs egibs deleted the wolfi-false-positve-overrides branch October 24, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants