Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-organize samples + integration tests to improve caching #593

Merged
merged 16 commits into from
Nov 6, 2024

Conversation

tstromberg
Copy link
Collaborator

@tstromberg tstromberg commented Nov 6, 2024

This re-organizes tests for speed:

  • re-use the cloned samples repo directory for new commits (just swap the commit out)
  • re-use previously decompressed files
  • remove the test_data file dance

To support this, this PR makes the following changes:

  • The out/samples-* folder is now named out/<name of org>/<name of repo>
  • The samples/ folder is no longer used
  • The test_data directory has been renamed tests
  • go test . now works from the newly named tests/ subdirectory
  • make test is now split into make integration (slow integration tests) and make test (fast unit tests).

@tstromberg tstromberg marked this pull request as draft November 6, 2024 13:19
@tstromberg tstromberg changed the title re-organize samples and test data for speed re-organize samples + integration tests to improve caching Nov 6, 2024
@tstromberg tstromberg marked this pull request as ready for review November 6, 2024 15:44
@tstromberg tstromberg requested a review from egibs November 6, 2024 15:44
@tstromberg tstromberg marked this pull request as draft November 6, 2024 15:53
@tstromberg tstromberg marked this pull request as ready for review November 6, 2024 16:08
Makefile Show resolved Hide resolved
@egibs egibs merged commit 19b5f8a into chainguard-dev:main Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants