Don't consider .mdiff or .sdiff files in discoverTestData #637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the bug seen here: https://github.com/chainguard-dev/malcontent/pull/636/files#r1845470148
I was considering
.mdiff
and.sdiff
files as part of the code that replaced this Bash:.mdiff
and.sdiff
files should only be handled by thediffRefresh
function and having them in two places caused drift/clobbering in cases where the filenames without extensions were the same (e.g.,ls.json
being scanned instead of thels
binary).With this code, I ran about 10 refresh loops and the problematic
ls.mdiff
file retained its header consistently:whereas the original code would flip back and forth between this and
## Changed: macOS/clean/ls.json
arbitrarily (depending on which Task was executed last).