Add new BubbleTea TUI renderer #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think about naming this renderer "interactive"? Technically the other renderers are TUI's as well. |
tstromberg
approved these changes
Dec 2, 2024
|
(approved, other than the renderer name and new merge conflicts) |
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new, separate terminal renderer that leverages BubbleTea for a more interactive experience that can be accessed via
--format tui. I also tweaked the normal terminal output to add additional color highlighting to strings.This new renderer allows for scrolling/keyboard navigation within the viewport as well as searching for specific strings.
There are likely some small bugs in the implementation (e.g., boxes rendering incorrectly if the terminal window is too small), but for the most part it works as expected for
analyze,diff, andscan.The main caveat when using this renderer is that [most] errors will be ignored to prevent breaking the interface.