-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for UPX files #731
Conversation
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
"RiskScore": 4, | ||
"RiskLevel": "CRITICAL" | ||
}, | ||
"/__min__c.~": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since UPX scans will result in two reports, we'll need to use JSON to maintain deterministic ordering.
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
One concern I had was the possibility that Otherwise this PR LGTM. |
Closes: #197
Now that we've been encountering UPX binaries in packages, it makes sense to add support for scanning these files.
The main issue with this is that UPX has to be installed, but otherwise scanning is as easy as copying the file into our temporary scan directory and then running
upx -d
.Before:
After:
Verification that we're not just decompressing the source file: