Allow for number of scanners to be configurable #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egibs
force-pushed
the
configurable-scanners
branch
3 times, most recently
from
a6f6a36 to
41e9c52
Compare
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
force-pushed
the
configurable-scanners
branch
from
41e9c52 to
43251f8
Compare
stevebeattie
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #760 -- turns out, yara-x is trying to reserve a large amount of memory for each scanner it creates which causes issues in Cloud Run.
To avoid this, we can make the number of scanners configurable (similar to overall concurrency).
I tested this and the performance difference between one scanner and the default of
runtime.NumCPUis about 7x for very large packages (number of files), so hopefully we can at least run 2-4 in Cloud Run. That said, we can always sacrifice performance for stability and most scans are in the tens of files, not hundreds of thousands.To set the new value, we'll just add
MaxScanners: <value>to the config where necessary (similar to the changes in the refresh code in this PR).