Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job control with interactive bubblewrap #1052

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

jonjohnsonjr
Copy link
Contributor

@jonjohnsonjr jonjohnsonjr commented Feb 29, 2024

This flag breaks job control, which only matters during --interactive debugging.

@jonjohnsonjr jonjohnsonjr marked this pull request as draft February 29, 2024 17:07
Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
@jonjohnsonjr jonjohnsonjr changed the title Print bubblewrap pid on debug Fix job control with interactive bubblewrap Feb 29, 2024
@jonjohnsonjr jonjohnsonjr marked this pull request as ready for review February 29, 2024 18:39
@imjasonh imjasonh merged commit 4678d38 into chainguard-dev:main Feb 29, 2024
32 checks passed
Copy link
Contributor

@smoser smoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants